Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set default model configuration for the Google provider. #131

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

adhintz
Copy link
Contributor

@adhintz adhintz commented Oct 9, 2024

Set default model configuration for the Google provider. This enables a working configuration just by specifying GOOGLE_API_KEY. Without this PR, the configuration defaults to OpenAI processor and accelerator values, which do not work for the Google provider.

I set it to use the flash version for both the processor and accelerator. The free tier allows 15 requests per minute for flash, but only 2 requests per minute for pro.

Also add Google to the list of providers.

Relevant issue: #129

Add Google to the list of providers.
@adhintz adhintz changed the title [fix] Set default model configuration for the Google provider. fix: Set default model configuration for the Google provider. Oct 9, 2024
Copy link
Collaborator

@lamchau lamchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lamchau lamchau requested a review from baxen October 9, 2024 18:05
@baxen baxen merged commit 798f346 into block:main Oct 10, 2024
4 of 5 checks passed
ahau-square added a commit that referenced this pull request Oct 10, 2024
* main:
  feat: add groq provider (#134)
  feat: add a deep thinking reasoner model (o1-preview/mini) (#68)
  fix: use concrete SessionNotifier (#135)
  feat: add guards to session management (#101)
  fix: Set default model configuration for the Google provider. (#131)
  test: convert Google Gemini tests to VCR (#118)
  chore: Add goose providers list command (#116)
  docs: working ollama for desktop (#125)
  docs: format and clean up warnings/errors (#120)
  docs: update deploy workflow (#124)
  feat: Implement a goose run command (#121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants